From 44bca7ba3a4c425d9c64039406d68530104b1bb3 Mon Sep 17 00:00:00 2001 From: takuya kodama Date: Fri, 23 May 2025 16:56:14 +0900 Subject: [PATCH] fix: move xml-model declaration above license header (#14) ## Problem When we launch openarm_bringup, the following error are raised. ```console $ ros2 launch openarm_bringup openarm.launch.py [INFO] [launch]: All log files can be found below /home/otegami/.ros/log/2025-05-23-15-07-52-834283-otegami-2239551 [INFO] [launch]: Default logging verbosity is set to INFO [INFO] [ros2_control_node-1]: process started with pid [2239568] [INFO] [robot_state_publisher-2]: process started with pid [2239569] [INFO] [rviz2-3]: process started with pid [2239570] [robot_state_publisher-2] [INFO] [1747984073.330768599] [robot_state_publisher]: Robot initialized [ros2_control_node-1] [INFO] [1747984073.346291338] [controller_manager]: Using Steady (Monotonic) clock for triggering controller manager cycles. [ros2_control_node-1] [ERROR] [1747984073.346957366] [pluginlib.ClassLoader]: Could not find a root element for package manifest at /home/otegami/work/cpp/ros2_ws/install/openarm_hardware/share/openarm_hardware/package.xml. [ros2_control_node-1] [ERROR] [1747984073.347001329] [pluginlib.ClassLoader]: Could not find package manifest (neither package.xml or deprecated manifest.xml) at same directory level as the plugin XML file /home/otegami/work/cpp/ros2_ws/install/openarm_hardware/share/openarm_hardware/openarm_hardware.xml. Plugins will likely not be exported properly. [ros2_control_node-1] ) [ros2_control_node-1] [ERROR] [1747984073.347237704] [pluginlib.ClassLoader]: Could not find a root element for package manifest at /home/otegami/work/cpp/ros2_ws/install/openarm_hardware/share/openarm_hardware/package.xml. [ros2_control_node-1] [ERROR] [1747984073.347246277] [pluginlib.ClassLoader]: Could not find package manifest (neither package.xml or deprecated manifest.xml) at same directory level as the plugin XML file /home/otegami/work/cpp/ros2_ws/install/openarm_hardware/share/openarm_hardware/openarm_hardware.xml. Plugins will likely not be exported properly. [ros2_control_node-1] ) [ros2_control_node-1] [ERROR] [1747984073.347465709] [pluginlib.ClassLoader]: Could not find a root element for package manifest at /home/otegami/work/cpp/ros2_ws/install/openarm_hardware/share/openarm_hardware/package.xml. [ros2_control_node-1] [ERROR] [1747984073.347471103] [pluginlib.ClassLoader]: Could not find package manifest (neither package.xml or deprecated manifest.xml) at same directory level as the plugin XML file /home/otegami/work/cpp/ros2_ws/install/openarm_hardware/share/openarm_hardware/openarm_hardware.xml. Plugins will likely not be exported properly. ``` ## Cause when the license comments appeared before the xml-model instruction, it happedned. ## Solution This PR changes places the xml-model declaration immediately after the XML prolog and ahead of the license block to resolve the issue. --- openarm/package.xml | 2 +- openarm_bimanual_bringup/package.xml | 2 +- openarm_bimanual_description/package.xml | 2 +- openarm_bimanual_moveit_config/package.xml | 2 +- openarm_bringup/package.xml | 2 +- openarm_description/package.xml | 2 +- openarm_hardware/package.xml | 2 +- openarm_moveit_config/package.xml | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/openarm/package.xml b/openarm/package.xml index 142c9ae..e49c6f5 100644 --- a/openarm/package.xml +++ b/openarm/package.xml @@ -1,4 +1,5 @@ + - openarm 0.3.0 diff --git a/openarm_bimanual_bringup/package.xml b/openarm_bimanual_bringup/package.xml index 621b3d6..21d70df 100644 --- a/openarm_bimanual_bringup/package.xml +++ b/openarm_bimanual_bringup/package.xml @@ -1,4 +1,5 @@ + - openarm_bimanual_bringup 0.3.0 diff --git a/openarm_bimanual_description/package.xml b/openarm_bimanual_description/package.xml index bf9f44e..f6de941 100644 --- a/openarm_bimanual_description/package.xml +++ b/openarm_bimanual_description/package.xml @@ -1,4 +1,5 @@ + - openarm_bimanual_description 0.3.0 diff --git a/openarm_bimanual_moveit_config/package.xml b/openarm_bimanual_moveit_config/package.xml index d44a158..4d67cc3 100644 --- a/openarm_bimanual_moveit_config/package.xml +++ b/openarm_bimanual_moveit_config/package.xml @@ -1,4 +1,5 @@ + - openarm_bimanual_moveit_config 0.3.0 diff --git a/openarm_bringup/package.xml b/openarm_bringup/package.xml index 3344e56..7996765 100644 --- a/openarm_bringup/package.xml +++ b/openarm_bringup/package.xml @@ -1,4 +1,5 @@ + - openarm_bringup 0.3.0 diff --git a/openarm_description/package.xml b/openarm_description/package.xml index 1ec339e..f85d0ad 100644 --- a/openarm_description/package.xml +++ b/openarm_description/package.xml @@ -1,4 +1,5 @@ + - openarm_description 0.3.0 diff --git a/openarm_hardware/package.xml b/openarm_hardware/package.xml index e149aad..dedf49b 100644 --- a/openarm_hardware/package.xml +++ b/openarm_hardware/package.xml @@ -1,4 +1,5 @@ + - openarm_hardware 0.3.0 diff --git a/openarm_moveit_config/package.xml b/openarm_moveit_config/package.xml index ebabcae..da8e626 100644 --- a/openarm_moveit_config/package.xml +++ b/openarm_moveit_config/package.xml @@ -1,4 +1,5 @@ + - openarm_moveit_config 0.3.0